> On 五月 6, 2016, 3:48 p.m., haosdent huang wrote: > > src/webui/master/static/directives/tableHeader.html, line 10 > > <https://reviews.apache.org/r/46966/diff/1/?file=1370624#file1370624line10> > > > > I think need to change it like > > ``` > > <span class="input-group-addon"...> > > <i class="glyphicon glyphicon-filter"></i> > > Find > > </span> > > ``` > > Because it should be the content of `input-group-addon`, not the > > content of glyphicon.
Yes, It's better. thanks - Chen Nan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46966/#review132050 ----------------------------------------------------------- On 五月 6, 2016, 1:29 a.m., Chen Nan Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46966/ > ----------------------------------------------------------- > > (Updated 五月 6, 2016, 1:29 a.m.) > > > Review request for mesos, Zhiwei Chen and haosdent huang. > > > Bugs: MESOS-5201 > https://issues.apache.org/jira/browse/MESOS-5201 > > > Repository: mesos > > > Description > ------- > > Form controls must have associated labels. > > > Diffs > ----- > > src/webui/master/static/directives/tableHeader.html > 448f67ef20c279fdd542890158fb9f96a10ebebc > > Diff: https://reviews.apache.org/r/46966/diff/ > > > Testing > ------- > > Using aria-label "search" to make screen reader to identify that the text > form is for search. > > and use content to replace placeholder to make the "Find"text more visible. > > Use of the placeholder attribute as a replacement for a programmatically > associated visible label can reduce the accessibility and usability of the > control for a range of users including older users and users with cognitive, > mobility. > > refer to > https://www.paciellogroup.com/blog/2011/02/html5-accessibility-chops-the-placeholder-attribute/ > > > Thanks, > > Chen Nan Li > >
