> On May 7, 2016, 1:22 p.m., haosdent huang wrote: > > src/docker/executor.cpp, line 398 > > <https://reviews.apache.org/r/46491/diff/6/?file=1375675#file1375675line398> > > > > Should it change to `if (killed || terminated ||..)`? > > Alexander Rukletsov wrote: > Currently, if `terminated == true` then `killed == true` as well. There > is no need to introduce an extra condition.
Got it, thx! - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/#review132136 ----------------------------------------------------------- On May 7, 2016, 1:02 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46491/ > ----------------------------------------------------------- > > (Updated May 7, 2016, 1:02 p.m.) > > > Review request for mesos, Benjamin Bannier and Ben Mahler. > > > Bugs: MESOS-5240 > https://issues.apache.org/jira/browse/MESOS-5240 > > > Repository: mesos > > > Description > ------- > > Capture the state when a task has terminated (i.e., reaped) in a flag, > and use it to prevent calls to `killTask()` and `escalated()` when > they are executed after the task has terminated. > > > Diffs > ----- > > src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 > src/launcher/executor.cpp 4d5e2a9b876cd65be1386bf170dba2f71af86750 > src/launcher/http_command_executor.cpp > d2f15b0447d91f3a4cd92f07114cb366647cc7d3 > > Diff: https://reviews.apache.org/r/46491/diff/ > > > Testing > ------- > > `make check` on Mac OS 10.10.4 > > > Thanks, > > Alexander Rukletsov > >