----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/#review132576 -----------------------------------------------------------
src/docker/spec.cpp (line 164) <https://reviews.apache.org/r/47199/#comment196810> Is there always a "config" and a "container_config" (below) in every image? If not, won't we error out unnecessarily here? src/docker/spec.cpp (line 171) <https://reviews.apache.org/r/47199/#comment196811> There are certainly not labels in every image. Is there always a section for them though, even if they are not present? Maybe not, because you call `isSome()` later on, but then the error message here is confusing. src/docker/spec.cpp (lines 171 - 174) <https://reviews.apache.org/r/47199/#comment196812> There are certainly not labels in every image. Is there always a section for them though, even if they are not present? Maybe not, because you call `isSome()` later on, but then the error message here is confusing. - Kevin Klues On May 10, 2016, 11:21 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47199/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 11:21 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, and Kevin > Klues. > > > Bugs: MESOS-5272 > https://issues.apache.org/jira/browse/MESOS-5272 > > > Repository: mesos > > > Description > ------- > > Implemented parsing docker labels in v1 spec. > > > Diffs > ----- > > src/docker/spec.cpp ac28331a17edb8c2ff81d5a2f79a794f869a3e5d > > Diff: https://reviews.apache.org/r/47199/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
