----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47001/#review132605 -----------------------------------------------------------
Ship it! Ship It! - Gilbert Song On May 4, 2016, 9:15 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47001/ > ----------------------------------------------------------- > > (Updated May 4, 2016, 9:15 p.m.) > > > Review request for mesos, Gilbert Song and Jiang Yan Xu. > > > Bugs: MESOS-5308 > https://issues.apache.org/jira/browse/MESOS-5308 > > > Repository: mesos > > > Description > ------- > > There are two race conditions in ROOT_XFS_QuotaTest.NoCheckpointRecovery. > The first is when we were checking the disk resources consumed > without knowing whether the dd command had completed. We can just > eliminate this check since other tests cover the resource usage > case. The second race was installing the > MesosContainerizerProcess::___recover expectation after starting > the slave. We need to install this before starting. > > > Diffs > ----- > > src/tests/containerizer/xfs_quota_tests.cpp > 61ea2e55e5c71cb10f6c84d23c205169567e8c96 > > Diff: https://reviews.apache.org/r/47001/diff/ > > > Testing > ------- > > Fedora 23. > > $ mesos-tests --gtest_filter=ROOT_XFS_QuotaTest.NoCheckpointRecovery > --gtest_repeat=10000 --gtest_break_on_failure > > > Thanks, > > James Peach > >
