----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46003/#review132771 -----------------------------------------------------------
src/local/local.cpp (line 348) <https://reviews.apache.org/r/46003/#comment197021> s/workDirTry/mkdir/ src/tests/containerizer/mesos_containerizer_tests.cpp (lines 115 - 122) <https://reviews.apache.org/r/46003/#comment197023> it would be nice to create the temp directory inside the sandbox. Try<string> workDirectory = os::mkdir("./work_dir"); alternatively, we can add a mkdtemp() method to the TemporaryDirectoryTest fixture that gives us a temporary directory inside the sandbox. src/tests/containerizer/mesos_containerizer_tests.cpp (line 410) <https://reviews.apache.org/r/46003/#comment197022> ditto. create temp inside sandbox. see above. - Vinod Kone On May 7, 2016, 1:28 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46003/ > ----------------------------------------------------------- > > (Updated May 7, 2016, 1:28 a.m.) > > > Review request for mesos, Michael Park and Vinod Kone. > > > Bugs: MESOS-5064 > https://issues.apache.org/jira/browse/MESOS-5064 > > > Repository: mesos > > > Description > ------- > > The default value for the agent's `--work_dir` flag was removed, the > type of the parameter was changed to `Option<string>`, and code was > added to explicitly set the work directory when necessary. > > > Diffs > ----- > > src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f > src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 > src/tests/containerizer/mesos_containerizer_tests.cpp > 09742ff21513dc2570684d384b257868dd57a9ce > > Diff: https://reviews.apache.org/r/46003/diff/ > > > Testing > ------- > > `sudo make check` > > > Thanks, > > Greg Mann > >
