----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44837/#review132992 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/mesos.proto (line 1575) <https://reviews.apache.org/r/44837/#comment197286> Understand it defaults to be false. Could we make it explicit here? Thanks! include/mesos/v1/mesos.proto (line 1574) <https://reviews.apache.org/r/44837/#comment197287> ditto. - Gilbert Song On April 18, 2016, 1:31 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44837/ > ----------------------------------------------------------- > > (Updated April 18, 2016, 1:31 a.m.) > > > Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu. > > > Bugs: MESOS-4886 > https://issues.apache.org/jira/browse/MESOS-4886 > > > Repository: mesos > > > Description > ------- > > Added force_pull_image to Image protobuf. > > > Diffs > ----- > > include/mesos/mesos.proto 87af4a06db8cc3889fe4d3b314206103f5ce5f2d > include/mesos/v1/mesos.proto 34da0a1484dc2f71262d8b97484b8edaae35bb6c > > Diff: https://reviews.apache.org/r/44837/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >