> On May 13, 2016, 3:16 p.m., Alexander Rukletsov wrote: > > src/slave/http.cpp, line 855 > > <https://reviews.apache.org/r/47339/diff/1/?file=1382448#file1382448line855> > > > > Do we need the first check given we explicitly requested `tokenize()` > > to split endpoint into two parts? > > Jan Schlicht wrote: > Size could be 0 or 1 if the input string doesn't look as expected -- > exactly what we're testing for here. > > Alexander Rukletsov wrote: > Maybe then s/!=/<=/ for documenting our intention?
Yeah, makes sense. The `!=2` could be a leftover from an older version that didn't use `tokenize()` and where values >2 were possible. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/#review133091 ----------------------------------------------------------- On May 13, 2016, 4:12 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47339/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 4:12 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > Extracting the HTTP endpoint from `URL.path` is now done in a separate > function in `Slave::Http`, making `Slave::Http::extractEndpoint` > consistent with the one in `Master::Http`. > > > Diffs > ----- > > src/master/http.cpp 6cefcc8b6ddcfe4098521e838bfdc95936fe7476 > src/master/master.hpp bd0fa9870199bb8792f6c2b8c24ad93da4f027e0 > src/slave/http.cpp 0fb9b81c4a87250e454e3380c61cf9037454810b > src/slave/slave.hpp be622d31de29a242a6c71fd8dedb06aeff19142d > > Diff: https://reviews.apache.org/r/47339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
