----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47403/#review133425 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/protobuf.hpp (lines 110 - 117) <https://reviews.apache.org/r/47403/#comment197845> How about: ``` const int operation_flags = O_WRONLY | O_CREAT | O_TRUNC | O_CLOEXEC; #ifdef __WINDOWS__ // NOTE: Windows does automatic linefeed conversions in I/O on text files. // We include the `_O_BINARY` flag here to avoid this. operation_flags |= _O_BINARY; #endif ``` - Joris Van Remoortere On May 15, 2016, 10:28 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47403/ > ----------------------------------------------------------- > > (Updated May 15, 2016, 10:28 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Bugs: MESOS-3443 and MESOS-3658 > https://issues.apache.org/jira/browse/MESOS-3443 > https://issues.apache.org/jira/browse/MESOS-3658 > > > Repository: mesos > > > Description > ------- > > In Windows, the I/O subsystem will automatically convert linefeed > endings if the I/O is done on "text" files. For binary files, this > effect is almost never desirable. > > This commit will turn of these conversions for protobuf I/O operations. > > > Diffs > ----- > > 3rdparty/stout/include/stout/protobuf.hpp > eb4ac8cd738859a119f4f64bf52ae49a5bbef899 > > Diff: https://reviews.apache.org/r/47403/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
