----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45605/#review133691 -----------------------------------------------------------
src/linux/routing/queueing/htb.cpp (line 49) <https://reviews.apache.org/r/45605/#comment198280> Why we pass `uint64_t` above and use `uint32_t` here? src/linux/routing/queueing/htb.cpp (line 100) <https://reviews.apache.org/r/45605/#comment198279> ``` return Error(string(nl_geterror(error))); ``` because `using std::string;` above. - haosdent huang On April 1, 2016, 9:50 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45605/ > ----------------------------------------------------------- > > (Updated April 1, 2016, 9:50 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: mesos-4749 > https://issues.apache.org/jira/browse/mesos-4749 > > > Repository: mesos > > > Description > ------- > > Introduced HTB class API, prepare for per-container bandwidth limit. > > > Diffs > ----- > > src/linux/routing/internal.hpp 8f68119819f7c79ece1a13ac1894b1802ddc8e19 > src/linux/routing/queueing/discipline.hpp > 54d6b214ef6a38fd8279f6d01e6f4e3ccfddf634 > src/linux/routing/queueing/htb.hpp 857646190d21387f98832f5094128505a52a0776 > src/linux/routing/queueing/htb.cpp faadf32bd48cc6bf968b1229789903c0d01fd75c > src/linux/routing/queueing/internal.hpp > 768ed325f9b259e150779eb3ad74f4e5d4bcc7a2 > > Diff: https://reviews.apache.org/r/45605/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Cong Wang > >