Re: Review Request 47510: Adjusted style to make website mobile friendly.

[Vinod Kone]

> On May 18, 2016, 6:05 p.m., Vinod Kone wrote:
> > site/source/layouts/layout.erb, lines 66-83
> > <https://reviews.apache.org/r/47510/diff/1/?file=1386346#file1386346line66>
> >
> >     what does this do?
> >     
> >     also, can you attach before and after screen shots?
> 
> Tim Anderegg wrote:
>     @vinodkone That section collapes the menu for mobile devices, which 
> addresses the comment I left on the other patch.  Without it, the menu takes 
> up a good portion of the screen until the user scrolls down, with this the 
> menu is hidden unless the user hits the new menu button.  The new menu button 
> is only displayed on mobile.

Gotcha. Thanks!


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47510/#review133774
-----------------------------------------------------------


On May 18, 2016, 6:04 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47510/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-3690
>     https://issues.apache.org/jira/browse/MESOS-3690
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adjusted style to make website mobile friendly.
> 
> 
> Diffs
> -----
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
>   site/source/layouts/layout.erb 2bf6967faad45644647b732be0fa3c410b9951c5 
> 
> Diff: https://reviews.apache.org/r/47510/diff/
> 
> 
> Testing
> -------
> 
> # Note
> @vinodkone, this should credited to @fayusohenson and @janisz when submit.
> I pick the necessary changes for mobile friendly from 
> https://github.com/apache/mesos/pull/75 .
> 
> And record some simple videos under mobile, tablet and pc to show this patch.
> 
> ![home_mobile.gif](https://issues.apache.org/jira/secure/attachment/12804724/home_mobile.gif)
> ![home_tablet.gif](https://issues.apache.org/jira/secure/attachment/12804726/home_tablet.gif)
> ![home_pc.gif](https://issues.apache.org/jira/secure/attachment/12804725/home_pc.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>