----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47400/#review133891 -----------------------------------------------------------
Fix it, then Ship it! Thanks a lot, Zhitao! I'll push it shortly. CHANGELOG (line 59) <https://reviews.apache.org/r/47400/#comment198560> Strictly speaking, ACLs are only for local authorizer, hence it's more inportant to say we deprecate actions. I'll rephrase. CHANGELOG (line 60) <https://reviews.apache.org/r/47400/#comment198559> Please wrap. docs/authorization.md (line 129) <https://reviews.apache.org/r/47400/#comment198561> "Updating" is a bit misleading. We want to reference all three actions: set, remove, and update. Let's say "Modifying". docs/authorization.md (line 130) <https://reviews.apache.org/r/47400/#comment198562> Not yours, but let's s/Roles/Resource roles/ for consistency. docs/authorization.md (line 525) <https://reviews.apache.org/r/47400/#comment198563> s/retrive/query. docs/authorization.md (line 555) <https://reviews.apache.org/r/47400/#comment198564> s/principals/principal. Here and above docs/quota.md (line 159) <https://reviews.apache.org/r/47400/#comment198565> s/retrieve/query docs/quota.md (line 189) <https://reviews.apache.org/r/47400/#comment198566> s/information/information We wrap at 80 chars for readability and diff'ability docs/upgrades.md (line 169) <https://reviews.apache.org/r/47400/#comment198567> I'll do minor tweaks here. - Alexander Rukletsov On May 19, 2016, 4:34 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47400/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 4:34 a.m.) > > > Review request for mesos, Adam B and Alexander Rukletsov. > > > Bugs: MESOS-5155 and MESOS-5336 > https://issues.apache.org/jira/browse/MESOS-5155 > https://issues.apache.org/jira/browse/MESOS-5336 > > > Repository: mesos > > > Description > ------- > > Documentation quota authorization changes in 0.29. > > > Diffs > ----- > > CHANGELOG 6bd59d191a8ca59436fa8a1953587119aeb3e256 > docs/authorization.md 9a359dc1c5576e9871c0747d02852bde35d67a3e > docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 > docs/upgrades.md 59274362fa6ec1e5857176fd5f8fd78c381f0d52 > > Diff: https://reviews.apache.org/r/47400/diff/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
