----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46874/#review134217 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/containerizer.cpp (line 1189) <https://reviews.apache.org/r/46874/#comment198854> Seems like the reporter in MESOS-5197 is requesting `LOG(INFO)`. Sorry for previous confusions. - Gilbert Song On May 9, 2016, 3:39 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46874/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 3:39 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5347 > https://issues.apache.org/jira/browse/MESOS-5347 > > > Repository: mesos > > > Description > ------- > > The mesos-containerizer will help prepare the rootfs, mount and > network conf for a container when launch with some flags, it > would be helpful to print out all of the mesos-containerizer launch > flags for trouble shooting. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 75e5a32a3e70ec60a6800e21a621673184ea0956 > > Diff: https://reviews.apache.org/r/46874/diff/ > > > Testing > ------- > > make > make check > > Enhanced log message: > I0501 14:12:17.910006 5991 containerizer.cpp:1175] Launching > 'mesos-containerizer' with flags > '--command="{"shell":true,"value":"\/root\/src\/mesos\/m1\/mesos\/build\/src\/mesos-executor"}" > --commands="{"commands":[{"shell":true,"value":"#!\/bin\/sh\nset -x > -e\n\/root\/src\/mesos\/m1\/mesos\/build\/src\/mesos-containerizer mount > --help=\"false\" --operation=\"make-rslave\" --path=\"\/\"\ngrep -E > '\/tmp\/mesos\/.+' \/proc\/self\/mountinfo | grep -v > 'a2cc264f-72eb-416c-b876-e4a98484a0ab' | cut -d' ' -f5 | xargs > --no-run-if-empty umount -l || true \n"}]}" --help="false" --pipe_read="8" > --pipe_write="9" > --sandbox="/tmp/mesos/slaves/5763efb9-8e12-4bfc-b06b-2a324881608d-S0/frameworks/425afd24-796d-42dd-98c0-593f1d71e246-0000/executors/test/runs/a2cc264f-72eb-416c-b876-e4a98484a0ab" > --user="root"' > > > Thanks, > > Guangya Liu > >
