----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/#review134342 -----------------------------------------------------------
Looks good Kapil! I would like to have tests and documentation updates as well before feeling comfortable to commit this - at least as [WIP] added here in a chain. src/master/flags.cpp (line 407) <https://reviews.apache.org/r/47123/#comment199143> Could you please add a similar comment as you did for the `modules` flag above, hinting that we need to keep stuff in sync? Same for all other references of that flag / help messages? - Till Toenshoff On May 20, 2016, 2:40 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47123/ > ----------------------------------------------------------- > > (Updated May 20, 2016, 2:40 a.m.) > > > Review request for mesos, Cody Maloney and Till Toenshoff. > > > Bugs: MESOS-5173 > https://issues.apache.org/jira/browse/MESOS-5173 > > > Repository: mesos > > > Description > ------- > > This allows the operator to use separate manifest JSON files for each > module. Previously, one had to merge all module manifest files into a > single JSON file before passing on to the master/agent. > > > Diffs > ----- > > src/master/flags.hpp d08509667c919e9cfd076762b622c18732edf910 > src/master/flags.cpp ceb4bd4f863d3857eede8287041a53d66f1c9e4c > src/master/main.cpp d00bbef2c4fb74544056ab81aeb4fcd6625b89fa > src/module/manager.hpp 9944af0daf6c9cb5a8ff338099401b1db88ee237 > src/module/manager.cpp 9f88ec3addab59e4a40b0b40612518178d535aa5 > src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 > src/sched/sched.cpp 9e55885704d5c4a8bc0e25e324b9c65e7bc34798 > src/slave/flags.hpp 3363412099ca2841e175bd6b6ed3d5f13605e6f0 > src/slave/flags.cpp 2d59329997197966f7d30d6f1375a988edbceb9c > src/slave/main.cpp 13ddfb9ae5a1ca240b738e67391ce5c5fc9ac0b6 > src/tests/flags.hpp ae232b1a087edfaf678bd1c67bc509efd6c740d8 > src/tests/main.cpp efec92286c78f7783e1de0781eb9e61c202a4fb8 > > Diff: https://reviews.apache.org/r/47123/diff/ > > > Testing > ------- > > Manual testing with: > 1. --module_dir > 2. --modules > 3. --module_dir in conjunction with --modules > > The first two succeeded while the third failed as expected. > > > Thanks, > > Kapil Arya > >
