> On May 23, 2016, 1:03 a.m., haosdent huang wrote: > > Do you forget to update > > * `framework.html` > > https://github.com/apache/mesos/blob/master/src/webui/master/static/framework.html#L24 > > * `agent.html` > > https://github.com/apache/mesos/blob/master/src/webui/master/static/agent.html > > > > * `agent_framework.html` > > https://github.com/apache/mesos/blob/master/src/webui/master/static/agent_framework.html
I thought that the change is required only on frameworks page. Thanks for bringing it up :-) I have made changes in framework.html. I have a few concerns/queries here: - The information displayed on Agents page is of agents only. So, I couldn't get you. What did you mean? - @Vinod/Hoasdent: The agent's state endpoint does not have framework-principal information. Shall I add only 'Role' field to agent.html and agent_framework.html or just leave it to be tackled later? - Deshna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/#review134296 ----------------------------------------------------------- On May 23, 2016, 9:08 p.m., Deshna Jain wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47702/ > ----------------------------------------------------------- > > (Updated May 23, 2016, 9:08 p.m.) > > > Review request for mesos, haosdent huang and Vinod Kone. > > > Bugs: MESOS-4788 > https://issues.apache.org/jira/browse/MESOS-4788 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/webui/master/static/framework.html > f108e92f5b8d9ed4de718e55aa7302728a84003e > src/webui/master/static/frameworks.html > f172e022e18df5b6aa3d232e610c3c732e20aa09 > > Diff: https://reviews.apache.org/r/47702/diff/ > > > Testing > ------- > > make check (see attached screenshot for ui after the change) > > > File Attachments > ---------------- > > image after making the change > > https://reviews.apache.org/media/uploaded/files/2016/05/23/a2b9738e-b33a-4fce-98b0-9457d42a31f7__Screen_Shot_2016-05-23_at_12.38.01_PM.png > > > Thanks, > > Deshna Jain > >
