> On 五月 23, 2016, 7:19 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp, line > > 93 > > <https://reviews.apache.org/r/44838/diff/5/?file=1383502#file1383502line93> > > > > WE don't use 'const' for primitive types. Please use `bool cached` here.
I saw that there are many places using `const bool`, such as https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/cgroups/mem.cpp#L75 , filed a JIRA https://issues.apache.org/jira/browse/MESOS-5443 for this. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/#review134420 ----------------------------------------------------------- On 五月 23, 2016, 11:30 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44838/ > ----------------------------------------------------------- > > (Updated 五月 23, 2016, 11:30 p.m.) > > > Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu. > > > Bugs: MESOS-4886 > https://issues.apache.org/jira/browse/MESOS-4886 > > > Repository: mesos > > > Description > ------- > > Enabled mesos containerizer do not cache image for docker. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp > 137af502a66e6a65773c00eaacbe392576376284 > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp > cf630cc0b67a325529fa04ad2b1708e013b9596a > src/slave/containerizer/mesos/provisioner/docker/store.cpp > eeec94326a4fd67675df10e0b6a32267e555fa96 > > Diff: https://reviews.apache.org/r/44838/diff/ > > > Testing > ------- > > make > make check > > It is difficult to test this with unit test, but just test with mesos execute > by setting `force_pull_image` as true and found that the iamge was always > pulled when `force_pull_image` is true. > > > Thanks, > > Guangya Liu > >
