> On May 23, 2016, 5:09 p.m., Adam B wrote: > > src/Makefile.am, lines 1937-1938 > > <https://reviews.apache.org/r/47374/diff/3/?file=1384789#file1384789line1937> > > > > Why does libmesos_tests_la_SOURCES need to include qos_controllers code?
I don't remember the exact reason, but one of my previous iterations (not published) broke on this module. It's unnecessary for the current implementation. > On May 23, 2016, 5:09 p.m., Adam B wrote: > > src/Makefile.am, lines 1991-1994 > > <https://reviews.apache.org/r/47374/diff/3/?file=1384789#file1384789line1991> > > > > I guess all these `tests/*.cpp` aren't needed anymore because they're > > covered in `libmesos_tests_la_SOURCES` which is also included in > > `mesos_tests_DEPENDENCIES` and `mesos_tests_LDADD`? Yup. These are all replaced with an `LDADD` later on. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/#review134476 ----------------------------------------------------------- On May 23, 2016, 7 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47374/ > ----------------------------------------------------------- > > (Updated May 23, 2016, 7 p.m.) > > > Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, Kapil Arya, Jan > Schlicht, and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > This gives external projects easier access to the test helpers used in > mesos tests. > > For example, a module writer may want to write a test like > `src/tests/oversubscription_tests.cpp`. To build and link against > this library, the module writer would mimic the build flags for tests: > ``` > my_module_tests_CPPFLAGS = \ > -I$(ZOOKEEPER)/include \ > -I$(ZOOKEEPER)/generated \ > -DSOURCE_DIR=\"$(abs_top_srcdir)\" \ > -DBUILD_DIR=\"$(abs_top_builddir)\" \ > ... > > my_module_tests_LDADD = libmesos_tests.la > ``` > > > Diffs > ----- > > src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 > > Diff: https://reviews.apache.org/r/47374/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
