> On 五月 23, 2016, 9:15 p.m., Jie Yu wrote: > > > > Jie Yu wrote: > Please make sure to a manual test. Why adding unit test is hard?
Yes, test manually. If adding a new unit test, I did not found a good way to check if the image was pulled from repo or just copied from local cache, any suggestions for this? Thanks. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44839/#review134437 ----------------------------------------------------------- On 五月 24, 2016, 2:01 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44839/ > ----------------------------------------------------------- > > (Updated 五月 24, 2016, 2:01 a.m.) > > > Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu. > > > Bugs: MESOS-4886 > https://issues.apache.org/jira/browse/MESOS-4886 > > > Repository: mesos > > > Description > ------- > > Enabled mesos containerizer force_pull_image for appc. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/appc/store.cpp > 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 > > Diff: https://reviews.apache.org/r/44839/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >