> On May 23, 2016, 6:31 p.m., Tomasz Janiszewski wrote:
> > site/README.md, line 12
> > <https://reviews.apache.org/r/47695/diff/2/?file=1391707#file1391707line12>
> >
> >     Running this command will end up with error: `unable to prepare 
> > context: unable to evaluate symlinks in context path: lstat no such file or 
> > directory`. Later this document assumed user is in `site` dir. To be 
> > consistend replace `site` with `.`

Oh, I former document, we suppose user under `mesos` root directory

```
docker build -t mesos/website support/site-docker
```

Let me describe this in the document.


> On May 23, 2016, 6:31 p.m., Tomasz Janiszewski wrote:
> > support/site-docker/Dockerfile, line 6
> > <https://reviews.apache.org/r/47695/diff/2/?file=1391710#file1391710line6>
> >
> >     Do we really need whole `Development Tools` to build website.

Good catch! We only need `gcc-c++ make` to build the native library when 
`bundle install`.


> On May 23, 2016, 6:31 p.m., Tomasz Janiszewski wrote:
> > site/README.md, line 47
> > <https://reviews.apache.org/r/47695/diff/2/?file=1391707#file1391707line47>
> >
> >     I think this section needs example that will work for 99% users.

Good suggestion! Let me add.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134408
-----------------------------------------------------------


On May 23, 2016, 5:49 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
>     https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> * updated `release-guide.md` with the new website generation and
>   development workflows.
> 
> 
> Diffs
> -----
> 
>   docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> -------
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> To verify website works fine after this changes, could check it via this gif:
> 
> ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to