> On 四月 11, 2016, 7:37 a.m., Guangya Liu wrote: > > src/uri/fetchers/docker.cpp, line 636 > > <https://reviews.apache.org/r/45952/diff/1/?file=1337596#file1337596line636> > > > > Add a log here to identify that the fetcher is now using auth to fetch > > the image? > > Guangya Liu wrote: > Adding the log in `getCredential` may be better, post some comments in > https://reviews.apache.org/r/45949/ , please check. Thanks. > > Gilbert Song wrote: > Thanks for the comments, Guangya! Seems like we dont have any log in > docker fetcher.
It will be very difficult for trouble shooting when I encounter some issue in fetcher, is it possible that you can put some log first for your project and we can add more log if needed? - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/#review128078 ----------------------------------------------------------- On 五月 23, 2016, 9:52 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45952/ > ----------------------------------------------------------- > > (Updated 五月 23, 2016, 9:52 p.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy > Chen. > > > Bugs: MESOS-4938 > https://issues.apache.org/jira/browse/MESOS-4938 > > > Repository: mesos > > > Description > ------- > > Implemented support for passing agent default docker config. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > eeec94326a4fd67675df10e0b6a32267e555fa96 > src/uri/fetchers/docker.hpp c855a2b55a07bb398f7547b44a85b8ba2d2b2ec3 > src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24 > > Diff: https://reviews.apache.org/r/45952/diff/ > > > Testing > ------- > > make check > > Tested with mesos-execute, using a private repo from docker hub. Both cases > are tested: > 1. --docker_registry=private_registry > 2. private_registry/repo > > > Thanks, > > Gilbert Song > >
