> On May 25, 2016, 5:14 a.m., Guangya Liu wrote: > > include/mesos/authorizer/authorizer.proto, line 69 > > <https://reviews.apache.org/r/47795/diff/1/?file=1392887#file1392887line69> > > > > New line above
Any reason why we need a new line here? excep for the deprecate entries we don't seem to use line breaks in this enum. > On May 25, 2016, 5:14 a.m., Guangya Liu wrote: > > src/authorizer/local/authorizer.cpp, lines 278-303 > > <https://reviews.apache.org/r/47795/diff/1/?file=1392888#file1392888line278> > > > > I think that the {} here is not needed. > > > > case authorization::ACCESS_SANDBOX_WITH_INFO: > > authorization::Request realRequest; > > ... > > return authorized(realRequest, acls_); > > break; It is needed because of the line ```c++ authorization::Request realRequest; ``` Since that is a declaration of a variable in an optional path, it ends being an error if there is no scope here. > On May 25, 2016, 5:14 a.m., Guangya Liu wrote: > > src/authorizer/local/authorizer.cpp, lines 279-292 > > <https://reviews.apache.org/r/47795/diff/1/?file=1392888#file1392888line279> > > > > Why not use `request` directly? Can you please show more detail or add > > some comments here? Request is `const` and the `frameworkInfo.role()` is the only field that needs to be extracted, we need to create an alternate one. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47795/#review134689 ----------------------------------------------------------- On May 24, 2016, 11:41 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47795/ > ----------------------------------------------------------- > > (Updated May 24, 2016, 11:41 p.m.) > > > Review request for mesos, Adam B, Benjamin Mahler, Joerg Schad, Michael Park, > and Vinod Kone. > > > Bugs: MESOS-5153 > https://issues.apache.org/jira/browse/MESOS-5153 > > > Repository: mesos > > > Description > ------- > > Enables authorization of the sandboxes using the callback function > parameter of `Files::attach()`. > > It also adds relevant ACLs and support on the authorizer interface. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > b178f53a299a2941afc073af963f6aff26af1ca8 > include/mesos/authorizer/authorizer.proto > 911a2271211249a41c4467f6754e9996f640bf38 > src/authorizer/local/authorizer.cpp > dc53bc4374aea98b5ed41ade5617374d2447229b > src/slave/slave.hpp 0de6a570e8b4699771048295ec3fcedf84593495 > src/slave/slave.cpp 2941cf1b6ea1e4deabfcbbe3f4897c06a28531a5 > > Diff: https://reviews.apache.org/r/47795/diff/ > > > Testing > ------- > > on OSX the script: > > ```bash > #! /usr/bin/env bash > > rm -rf /tmp/mesos/* > > cat <<EOF > /tmp/credentials.txt > foo bar > baz bar > EOF > > cat <<EOF > /tmp/acls.json > { > "permissive": false, > "access_sandboxes" : [ > { > "principals" : { "values" : ["foo"] }, > "roles" : { "values" : ["test"] } > } > ] > } > EOF > > ./mesos-master.sh --work_dir=/tmp/mesos/master & > ./mesos-slave.sh --work_dir=/tmp/mesos/slave \ > --master=127.0.0.1:5050 \ > --authenticate_http \ > --http_credentials=file:///tmp/credentials.txt \ > --acls=file:///tmp/acls.json & > > ./mesos-execute --command='while true; do echo "Hello world"; sleep 3; done' \ > --role=test \ > --master=127.0.0.1:5050 \ > --name=echoer & > > SANDBOX_VPATH=`http GET http://127.0.0.1:5051/files/debug -a foo:bar -b > --pretty=none \ > | python -c 'import json,sys;obj=json.load(sys.stdin);print > obj.keys()[0]'` > > # This should yield a 200 OK response > http GET http://127.0.0.1:5051/files/download?path=${SANDBOX_VPATH}/stdout -a > foo:bar > > # HTTP/1.1 200 OK > # Content-Disposition: attachment; filename=stdout > # Content-Length: 3267 > # Content-Type: application/octet-stream > # Date: Fri, 20 May 2016 13:52:31 GMT > # > # Received SUBSCRIBED event > # Subscribed executor on localhost > # Received LAUNCH event > # Starting task echoer > # sh -c 'while true; do echo "Hello world"; sleep 3; done' > # Forked command at 26162 > # Hello world > # Hello world > # Hello world > # Hello world > # Hello world > > # This shold yield a 403 Forbidden response > http GET http://127.0.0.1:5051/files/download?path=${SANDBOX_VPATH}/stdout -a > baz:bar > > # HTTP/1.1 403 Forbidden > # Content-Length: 0 > # Date: Fri, 20 May 2016 13:52:37 GMT > # > # > # > > ``` > > > Thanks, > > Alexander Rojas > >
