----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47843/#review134833 -----------------------------------------------------------
src/launcher/fetcher.cpp (lines 76 - 80) <https://reviews.apache.org/r/47843/#comment199758> can we use the updated `paths::join` here to simplify this? Can you add a JIRA to add an OS agnostic helper to quote command line arguments? This would have simplified this review a LOT :-) src/launcher/fetcher.cpp (lines 112 - 113) <https://reviews.apache.org/r/47843/#comment199759> Please add a comment referencing the JIRA for adding support to Windows for hadoop src/launcher/fetcher.cpp (lines 179 - 185) <https://reviews.apache.org/r/47843/#comment199760> So is the expecation here that we may receive linux style paths, and we want them to work flawlessly on windows? Can we prefix the code with that goal? src/launcher/fetcher.cpp (line 190) <https://reviews.apache.org/r/47843/#comment199761> Not sure why you're changing this check. The posix version isn't restricted to returning -1 for error? src/launcher/fetcher.cpp (lines 249 - 250) <https://reviews.apache.org/r/47843/#comment199762> Comment. src/launcher/fetcher.cpp (line 309) <https://reviews.apache.org/r/47843/#comment199763> Is necessary the right word? It's only 'not necessary' because we don't have a permissions model on Windows, right? src/launcher/fetcher.cpp (line 374) <https://reviews.apache.org/r/47843/#comment199764> same comment as above. - Joris Van Remoortere On May 25, 2016, 6:48 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47843/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 6:48 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Bugs: MESOS-3618 > https://issues.apache.org/jira/browse/MESOS-3618 > > > Repository: mesos > > > Description > ------- > > Agent: Added Windows support for launcher/fetcher.cpp. > > > Diffs > ----- > > src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 > > Diff: https://reviews.apache.org/r/47843/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
