> On May 25, 2016, 6:25 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, lines 150-152
> > <https://reviews.apache.org/r/47214/diff/2/?file=1384608#file1384608line150>
> >
> >     Is this change absolutely necessary for the ticket?
> 
> Jie Yu wrote:
>     Oh, i see that being useful in the following patch.
> 
> Jie Yu wrote:
>     In fact, i still prefer iterating all the flags in the callers, just to 
> be more explicit. It's not clear to me here what toVector means by just 
> looking at the name.

Ok, I can drop this patch and the previous one 
(https://reviews.apache.org/r/47213/).  

And then modify the following patch (https://reviews.apache.org/r/47215/) to 
explicitly enumerate the flags.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47214/#review134892
-----------------------------------------------------------


On May 16, 2016, 11:01 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47214/
> -----------------------------------------------------------
> 
> (Updated May 16, 2016, 11:01 a.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
>     https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> 44073146118b6c6e9e730b8c901852594080a3eb 
> 
> Diff: https://reviews.apache.org/r/47214/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to