----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47215/ -----------------------------------------------------------
(Updated May 25, 2016, 7:21 p.m.) Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya. Changes ------- Explicitly perform the flag stringification inside the docker containerizer helper. Bugs: MESOS-5350 https://issues.apache.org/jira/browse/MESOS-5350 Repository: mesos Description ------- This changes how we override the `CommandInfo` when launching a dockerized executor; from `shell == true` to `shell = false`. This means that flags are now passed directly rather than as a long string. i.e. From: 'mesos-docker-executor --foo="bar" --some="thing"' To: [ 'mesos-docker-executor', '--foo=bar', '--some=thing' ] Diffs (updated) ----- src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 Diff: https://reviews.apache.org/r/47215/diff/ Testing ------- make check Thanks, Joseph Wu