----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47971/#review135284 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1065) <https://reviews.apache.org/r/47971/#comment200300> We use camelCase for variables in Mesos. `s/ip_address/ipAddress` src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 1065 - 1067) <https://reviews.apache.org/r/47971/#comment200302> I would move this down after we get `ip`. No need to do this if `parse` below fails, right? src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 1088 - 1090) <https://reviews.apache.org/r/47971/#comment200303> Hum, you're parsing an ipv6 address using AF_INET? I don't think IPNetwork::parse supports AF_INET6 yet. You should either add IPV6 support to `parse`, or add a TODO here. - Jie Yu On May 27, 2016, 5:19 p.m., Dan Osborne wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47971/ > ----------------------------------------------------------- > > (Updated May 27, 2016, 5:19 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5453 > https://issues.apache.org/jira/browse/MESOS-5453 > > > Repository: mesos > > > Description > ------- > > Remove the prefix length included in the IP address string > that is returned by the CNI plugin before storing the value > in NetworkInfo.IPAddress. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 2ba3d62041379f5175b58f8c1ba3c2eae73edcf6 > > Diff: https://reviews.apache.org/r/47971/diff/ > > > Testing > ------- > > > Thanks, > > Dan Osborne > >
