----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48012/#review135397 -----------------------------------------------------------
Patch looks great! Reviews applied: [48008, 48009, 48010, 48011, 48012] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 28, 2016, 8:30 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48012/ > ----------------------------------------------------------- > > (Updated May 28, 2016, 8:30 p.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues. > > > Bugs: MESOS-2720 > https://issues.apache.org/jira/browse/MESOS-2720 > > > Repository: mesos > > > Description > ------- > > The idea is to extract JSON::Object representation of flags into a > function that can be used by both the old JSON REST API handler and the > new v1 API handler. > > > Diffs > ----- > > src/Makefile.am f1bd5e6e5515535c2aaf9ea8b205f4e8c7096ec5 > src/internal/evolve.hpp 4d1cb7f2a180f4f4a44491393393449d36ed616b > src/internal/evolve.cpp e7afcdb629a509e8bb30ba29542f360066eb8ad4 > src/master/http.cpp bbbf0a00e486b96e036f59a3107789d0322bc6cd > src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 > src/master/master.cpp 6442762c9fdfa368d5d9d7cd43b97f5addaf7f17 > src/master/validation.hpp 580f420a72f33290bcbe718bad839084d4209b8c > src/master/validation.cpp 982b61da5fe34dbe46190477e75ee7a4e4cdce9c > src/tests/api_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/48012/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
