----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/#review135434 -----------------------------------------------------------
Ship it! Barring others comments, LGTM! - Benjamin Hindman On May 29, 2016, 6:56 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48008/ > ----------------------------------------------------------- > > (Updated May 29, 2016, 6:56 a.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues. > > > Bugs: MESOS-2257 and MESOS-2720 > https://issues.apache.org/jira/browse/MESOS-2257 > https://issues.apache.org/jira/browse/MESOS-2720 > > > Repository: mesos > > > Description > ------- > > Also added common protos to v1/mesos.proto. > > > Diffs > ----- > > include/mesos/master/allocator.proto > 555f51b621b21b87b8db00b9ea62cd911d229504 > include/mesos/v1/agent.hpp PRE-CREATION > include/mesos/v1/agent.proto PRE-CREATION > include/mesos/v1/master.hpp PRE-CREATION > include/mesos/v1/master.proto PRE-CREATION > include/mesos/v1/mesos.proto af95b5233158c68db356a4c178d9811cf7bf665d > > Diff: https://reviews.apache.org/r/48008/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >