----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48038/#review135548 -----------------------------------------------------------
src/authorizer/local/authorizer.cpp (line 349) <https://reviews.apache.org/r/48038/#comment200573> Introducing `approved()` looks like a general enhancement. Maybe do it in a separate patch? src/authorizer/local/authorizer.cpp (lines 364 - 367) <https://reviews.apache.org/r/48038/#comment200574> You make these now private. Is it on purpose? Do you want to do it in a separate patch explaining the reasoning? - Alexander Rukletsov On May 30, 2016, 1:17 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48038/ > ----------------------------------------------------------- > > (Updated May 30, 2016, 1:17 p.m.) > > > Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod > Kone, and Zhitao Li. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/authorizer/local/authorizer.cpp > 547bbdd6c3605eadd23d2d2717a3fd362a616de5 > > Diff: https://reviews.apache.org/r/48038/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
