----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/#review135588 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/filesystem/windows.cpp (lines 17 - 22) <https://reviews.apache.org/r/47536/#comment200623> I don't think you use these? src/slave/containerizer/mesos/isolators/filesystem/windows.cpp (lines 30 - 36) <https://reviews.apache.org/r/47536/#comment200622> I don't think you use these? - Joris Van Remoortere On May 28, 2016, 7:38 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47536/ > ----------------------------------------------------------- > > (Updated May 28, 2016, 7:38 a.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Bugs: MESOS-3619, MESOS-3620 and MESOS-3683 > https://issues.apache.org/jira/browse/MESOS-3619 > https://issues.apache.org/jira/browse/MESOS-3620 > https://issues.apache.org/jira/browse/MESOS-3683 > > > Repository: mesos > > > Description > ------- > > Agent: Added Windows isolators. > > > Diffs > ----- > > src/CMakeLists.txt 9eabd781763adba39b60526c1b4a7d99b3bbbbf1 > src/Makefile.am f1bd5e6e5515535c2aaf9ea8b205f4e8c7096ec5 > src/slave/containerizer/mesos/isolators/filesystem/posix.hpp > 01ab1793d3d5469e6590617326b5e77e56bc7c50 > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > cb42d83a779c63c9ae25bbe72292aba3fe4cb8c9 > src/slave/containerizer/mesos/isolators/filesystem/windows.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/filesystem/windows.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/posix.hpp > 227505a70a440f15e68ac001878bcf25610db45f > src/slave/containerizer/mesos/isolators/windows.hpp PRE-CREATION > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 9e803f6ae55f09f7e871c60531acce16ebd5e8fe > src/usage/main.cpp ab3bb233caf6ba02af1b306dcf31d2b9ba6e322a > src/usage/usage.hpp 2e1996a78c617c2559ef882ebede5c8aab6f899f > src/usage/usage.cpp 3b19682e67372b81484eacddbab78c2e5eda3c5b > > Diff: https://reviews.apache.org/r/47536/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >