> On June 1, 2016, 3:28 a.m., Vinod Kone wrote: > > src/master/http.cpp, lines 3251-3255 > > <https://reviews.apache.org/r/48084/diff/2/?file=1402970#file1402970line3251> > > > > sorry missed this the last round but can you put this code in an > > evolve() function that takes v1::maintenanceStatus and returns > > v1::master::Response?
Thanks a lot for your quick reply, let me rework this patch with UPDATE_MAINTENANCE_SCHEDULE and GET_MAINTENANCE_SCHEDULE together. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/#review135758 ----------------------------------------------------------- On June 1, 2016, 2:13 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48084/ > ----------------------------------------------------------- > > (Updated June 1, 2016, 2:13 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5503 > https://issues.apache.org/jira/browse/MESOS-5503 > > > Repository: mesos > > > Description > ------- > > Implemented v1::master::Call::GET_MAINTENANCE_STATUS. > > > Diffs > ----- > > src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 > src/internal/evolve.cpp c255195b69f55f6429beed6c18a4a31b38528840 > src/master/http.cpp 12453261f73a0410f00287dec7fb3f106fb5cba8 > src/master/master.hpp 846edf37d13b44093832ca3d184426b403174b35 > src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 > > Diff: https://reviews.apache.org/r/48084/diff/ > > > Testing > ------- > > Test on CentOS 7 (gcc 4.8.5) > > ``` > $ ./bin/mesos-tests.sh --gtest_filter="*GetMaintenanceStatus*" > [==========] Running 2 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 2 tests from ContentType/MasterAPITest > [ RUN ] ContentType/MasterAPITest.GetMaintenanceStatus/0 > [ OK ] ContentType/MasterAPITest.GetMaintenanceStatus/0 (203 ms) > [ RUN ] ContentType/MasterAPITest.GetMaintenanceStatus/1 > [ OK ] ContentType/MasterAPITest.GetMaintenanceStatus/1 (51 ms) > [----------] 2 tests from ContentType/MasterAPITest (254 ms total) > > [----------] Global test environment tear-down > [==========] 2 tests from 1 test case ran. (279 ms total) > [ PASSED ] 2 tests. > ``` > > ``` > $ ./bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest*" > [==========] Running 11 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 11 tests from MasterMaintenanceTest > [ RUN ] MasterMaintenanceTest.UpdateSchedule > [ OK ] MasterMaintenanceTest.UpdateSchedule (126 ms) > [ RUN ] MasterMaintenanceTest.FailToUnscheduleDeactivatedMachines > [ OK ] MasterMaintenanceTest.FailToUnscheduleDeactivatedMachines (61 ms) > [ RUN ] MasterMaintenanceTest.PendingUnavailabilityTest > [ OK ] MasterMaintenanceTest.PendingUnavailabilityTest (141 ms) > [ RUN ] MasterMaintenanceTest.PreV1SchedulerSupport > [ OK ] MasterMaintenanceTest.PreV1SchedulerSupport (72 ms) > [ RUN ] MasterMaintenanceTest.EnterMaintenanceMode > [ OK ] MasterMaintenanceTest.EnterMaintenanceMode (227 ms) > [ RUN ] MasterMaintenanceTest.BringDownMachines > [ OK ] MasterMaintenanceTest.BringDownMachines (68 ms) > [ RUN ] MasterMaintenanceTest.BringUpMachines > [ OK ] MasterMaintenanceTest.BringUpMachines (69 ms) > [ RUN ] MasterMaintenanceTest.MachineStatus > [ OK ] MasterMaintenanceTest.MachineStatus (53 ms) > [ RUN ] MasterMaintenanceTest.InverseOffers > [ OK ] MasterMaintenanceTest.InverseOffers (120 ms) > [ RUN ] MasterMaintenanceTest.InverseOffersFilters > [ OK ] MasterMaintenanceTest.InverseOffersFilters (284 ms) > [ RUN ] MasterMaintenanceTest.EndpointsBadAuthentication > [ OK ] MasterMaintenanceTest.EndpointsBadAuthentication (63 ms) > [----------] 11 tests from MasterMaintenanceTest (1288 ms total) > > [----------] Global test environment tear-down > [==========] 11 tests from 1 test case ran. (1316 ms total) > [ PASSED ] 11 tests. > ``` > > > Thanks, > > haosdent huang > >
