----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/#review135801 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp (line 150) <https://reviews.apache.org/r/45086/#comment200847> Not sure why you want to add `cgroups/cpuacct` here. Actually in the `creator` hashmap below, I do not see `cgroups/cpuacc` as a key, i.e., no create() method corresponding to `cgroups/cpuacc`. So I guess an `Unknown or unsupported isolator` error will happen when `cgroups/cpuacc` is specified as the value of `--isolation`. src/slave/containerizer/mesos/containerizer.cpp (lines 242 - 245) <https://reviews.apache.org/r/45086/#comment200846> This seems not consistent with the design doc. In the design doc, I think we are going to introduce a new isolation mechanism `cgroups/unified` and a new flag `--cgroups_subsystems`, but here I see we reuse the existing cgroups isolation mechanisms. Maybe the design doc should be updated? src/slave/containerizer/mesos/containerizer.cpp (line 265) <https://reviews.apache.org/r/45086/#comment200848> I think you need to handle `cgroups/devices/gpus/nvidia` which also starts with `cgroups` :-) - Qian Zhang On April 16, 2016, 6:29 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45086/ > ----------------------------------------------------------- > > (Updated April 16, 2016, 6:29 p.m.) > > > Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian > Downes, Jie Yu, and Kevin Klues. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Enable cgroups unified isolator in isolation. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 1e1a36903f4377497bb72b69e4ead63675d453c0 > > Diff: https://reviews.apache.org/r/45086/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
