----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47396/#review136284 -----------------------------------------------------------
Fix it, then Ship it! src/linux/fs.hpp (line 169) <https://reviews.apache.org/r/47396/#comment201301> Can you split this patch? I would add `aufs::supported()` in the first patch, and add the backend in the second patch. - Jie Yu On June 6, 2016, 3:08 p.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47396/ > ----------------------------------------------------------- > > (Updated June 6, 2016, 3:08 p.m.) > > > Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu. > > > Bugs: MESOS-4672 > https://issues.apache.org/jira/browse/MESOS-4672 > > > Repository: mesos > > > Description > ------- > > Added aufs provisioning backend. > > > Diffs > ----- > > src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 > src/linux/fs.hpp 53faf248297a16dcacf693ebf645a1fcd5477666 > src/linux/fs.cpp 3573c3096afe990cbb0c3b411c688fe699cd9e55 > src/slave/containerizer/mesos/provisioner/backend.cpp > b2a20b7c08fa790da09ba05b725248e42b8d3bc4 > src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION > src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION > src/tests/containerizer/provisioner_backend_tests.cpp > bc04760c9504ea55cd4bb72c7e9012e43a5911aa > src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf > > Diff: https://reviews.apache.org/r/47396/diff/ > > > Testing > ------- > > - Make check on ubuntu 14.04 64bit > - Test manually: start slave with aufs backend, and write a simple script > that launches tasks with alpine/ubuntu images > > > Thanks, > > Shuai Lin > >
