----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45951/#review136361 -----------------------------------------------------------
src/uri/fetchers/docker.cpp (line 285) <https://reviews.apache.org/r/45951/#comment201383> Not yours, but can you fix the indentation in a follow up patch? Thanks! src/uri/fetchers/docker.cpp (lines 640 - 642) <https://reviews.apache.org/r/45951/#comment201400> Instead of merging logics in a single helper function, I would suggest that we introduce two helpers: ``` getAuthHeaderBasic(); getAuthHeaderBearer(); ``` - Jie Yu On May 25, 2016, 1:33 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45951/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 1:33 a.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy > Chen. > > > Bugs: MESOS-4938 > https://issues.apache.org/jira/browse/MESOS-4938 > > > Repository: mesos > > > Description > ------- > > Implemented http basic auth to get docker auth token. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24 > > Diff: https://reviews.apache.org/r/45951/diff/ > > > Testing > ------- > > make check > > Tested with mesos-execute, using a private repo from docker hub. > > > Thanks, > > Gilbert Song > >
