----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/#review136528 -----------------------------------------------------------
It might also be nice to add an ExamplesTest for this framework. (In another review perhaps?) i.e. https://github.com/apache/mesos/blob/master/src/tests/examples_tests.cpp src/examples/disk_full_framework.cpp (lines 89 - 96) <https://reviews.apache.org/r/46626/#comment201588> Looks like there are currently two scenarios: 1) Disk quota is enforced -> task fails. 2) Disk quota is not enforced -> task finishes. Can you add an option so that we can perform a sanity (null hypothesis) check? i.e. The task uses less disk than it requested. src/examples/disk_full_framework.cpp (line 299) <https://reviews.apache.org/r/46626/#comment201586> Per Vinod's comments (on /r/48303/ and /r/45905/) can you split your framework into a libprocess process? Tentatively see /r/48303/ for how I split the balloon framework. src/examples/disk_full_framework.cpp (line 310) <https://reviews.apache.org/r/46626/#comment201597> This should be tracked separately from `abnormal_terminations`. src/examples/disk_full_framework.cpp (lines 311 - 312) <https://reviews.apache.org/r/46626/#comment201595> I think both `tasks_lost_killed_error` and `tasks_failed` (with the exception of disk-full-related failures) fall under `abnormal_terminations`. It doesn't seem too valuable to track them separately. src/examples/disk_full_framework.cpp (lines 313 - 314) <https://reviews.apache.org/r/46626/#comment201594> `tasks_disk_full` == `allowed_terminations`. I'd get rid of `allowed_terminations`. - Joseph Wu On June 7, 2016, 9:56 a.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46626/ > ----------------------------------------------------------- > > (Updated June 7, 2016, 9:56 a.m.) > > > Review request for mesos and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Added example framework for testing disk quota enforcement. > > > Diffs > ----- > > src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 > src/examples/disk_full_framework.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46626/diff/ > > > Testing > ------- > > > Thanks, > > Artem Harutyunyan > >
