----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48366/ -----------------------------------------------------------
Review request for mesos and Benjamin Mahler. Bugs: MESOS-5257 https://issues.apache.org/jira/browse/MESOS-5257 Repository: mesos Description ------- This commit also includes updates to the tests that would start failing once GPU autodiscovery was turned on. Since GPUs are now a first class resource, we have to explicilty list them in resource vectors that attempt to set resources for the whole machine and then verify that they get the same vector back in an offer. Diffs ----- src/slave/containerizer/containerizer.cpp faa0c789dda8a6f36fdb6217b0bae270b6b8f2e2 src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp 7849e518af448d9557ca4d6de4ccaba8bc572992 src/tests/master_allocator_tests.cpp ec46913e7fed4bc8cda68ff20d04d6714ecb644d src/tests/master_quota_tests.cpp 62aaafe7b11a7df1ca7bc1f2f29af4cb626fc35d src/tests/master_tests.cpp 34be015aa314a7574e9065efb7b1bb8e1570c5b7 src/tests/mesos.hpp 6f2888023c957f0af4f7374c98e406816a8423e3 src/tests/persistent_volume_endpoints_tests.cpp 70b7626c8e87d1de59b13f9fd88fe9abb5f6b6a5 src/tests/slave_tests.cpp 7ba03e8c06b8aaac1e57124c257660acd8c1d78a Diff: https://reviews.apache.org/r/48366/diff/ Testing ------- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues