----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48371/#review136575 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (line 84) <https://reviews.apache.org/r/48371/#comment201665> Need a newline before this line. - Qian Zhang On June 8, 2016, 6:46 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48371/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 6:46 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5557 > https://issues.apache.org/jira/browse/MESOS-5557 > > > Repository: mesos > > > Description > ------- > > This component is designed to serve as a centralized component for > allocating / deallocating Nvidia GPUs. The goal is to share an > instance of this across both the mesos containerizer and the docker > containerizer so they can allocate GPUs from the same shared pool. > > It is overloaded to also do resource enumeration of GPUs based on > the agent flags. This keeps all code for enumerating GPUs and the > resources they represent in a single centralized location. > > > Diffs > ----- > > src/Makefile.am 29525c960e8fb2448260efdd774fd8fc1d68047b > src/slave/containerizer/mesos/isolators/gpu/allocator.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/gpu/allocator.cpp PRE-CREATION > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp > b1e64b2fc5518463cd14e119f89e3cd298286052 > > Diff: https://reviews.apache.org/r/48371/diff/ > > > Testing > ------- > > GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests > > > Thanks, > > Kevin Klues > >
