----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48563/#review137072 -----------------------------------------------------------
Fix it, then Ship it! Can you include the reason this segfaults in the description? i.e. because `jsonify` is not running in the master actor, it may try to read a field as the field is removed. src/master/http.cpp (lines 1869 - 1871) <https://reviews.apache.org/r/48563/#comment202219> You may want to update the spacing here. Spacing elsewhere looks fine. - Joseph Wu On June 10, 2016, 1:41 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48563/ > ----------------------------------------------------------- > > (Updated June 10, 2016, 1:41 p.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-5587 > https://issues.apache.org/jira/browse/MESOS-5587 > > > Repository: mesos > > > Description > ------- > > Previously the continuation followed via `.then([=]`, > which potentially executes the continuation on a differen > process. This patch fixes this behavior (it should > run on the master process). > > > Diffs > ----- > > src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 > > Diff: https://reviews.apache.org/r/48563/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
