----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48566/#review137075 -----------------------------------------------------------
Fix it, then Ship it! LGTM! src/files/files.cpp (lines 723 - 737) <https://reviews.apache.org/r/48566/#comment202222> It would be nice to add, in the review description, that you are fixing the potential race between this section of `::resolve` and `::detach` - Joseph Wu On June 10, 2016, 2:25 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48566/ > ----------------------------------------------------------- > > (Updated June 10, 2016, 2:25 p.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-5587 > https://issues.apache.org/jira/browse/MESOS-5587 > > > Repository: mesos > > > Description > ------- > > Previously the continuation followed via `.then([=]`, > which potentially executes the continuation on a different > process. This patch fixes this behavior (it should > run on the same process). > > > Diffs > ----- > > src/files/files.cpp 55c310af149cb03abfa1ffbb6477dc1ac5dc14be > > Diff: https://reviews.apache.org/r/48566/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
