> On June 15, 2016, 11 a.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/posix/su.hpp, line 219 > > <https://reviews.apache.org/r/47667/diff/5/?file=1420270#file1420270line219> > > > > Per your TODO above, maxgroups will be 16 on OSX. If ngroups is greater > > than 16, what will happen?
Then, `::syscall(SYS_initgroups, ngroups, _gids, uid.get())` will fail. On OS X, any `ngroups` greater than 16 in `::syscall(SYS_initgroups, ngroups, _, _)` would be regarded as `Invalid argument`. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47667/#review137784 ----------------------------------------------------------- On June 15, 2016, 10:46 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47667/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 10:46 a.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin > Klues, and Timothy Chen. > > > Bugs: MESOS-4757 > https://issues.apache.org/jira/browse/MESOS-4757 > > > Repository: mesos > > > Description > ------- > > Added stout functions to get and set supplementary groud ids. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/su.hpp > 0a3f23918be9f4d0b044cd9c45001114bc36fce5 > > Diff: https://reviews.apache.org/r/47667/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
