> On June 14, 2016, 11:40 a.m., Anand Mazumdar wrote: > > This is looking much better. > > > > Can you include both `flags.hpp/flags.cpp` in `src/Makefile.am`? This would > > fix the ReviewBot build failures. > > Anand Mazumdar wrote: > Hey Jose, I see that you marked the issues as resolved. Did you forget > publishing the updated diff? > > Also, did you add the new files to the Makefile as per my earlier comment?
I did not update the diff yet because I was running a full build in my local machine with the last commits. I just saw that some unit tests failed, I would like to solve the issues before upload the diff. - Jose Guilherme ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48387/#review137507 ----------------------------------------------------------- On June 13, 2016, 8:20 p.m., Jose Guilherme Vanz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48387/ > ----------------------------------------------------------- > > (Updated June 13, 2016, 8:20 p.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: MESOS-5359 > https://issues.apache.org/jira/browse/MESOS-5359 > > > Repository: mesos > > > Description > ------- > > The scheduler library has been updated to wait a little deley before > initiate a connection with the master. The maximum amount of time waited > by the scheduler is defined by a flag: CONNECTION_DELAY_MAX. After > the master has been detected the scheduler picks a random delay that > can be between 0 and the CONNECTION_DELAY_MAX value. MESOS-5359 > > > Diffs > ----- > > src/scheduler/constants.hpp PRE-CREATION > src/scheduler/flags.hpp PRE-CREATION > src/scheduler/scheduler.cpp c79837c93e7329dbfa22e4288b44237f33408ba9 > > Diff: https://reviews.apache.org/r/48387/diff/ > > > Testing > ------- > > > Thanks, > > Jose Guilherme Vanz > >
