> On June 16, 2016, 9:47 p.m., Joseph Wu wrote: > > src/tests/log_tests.cpp, lines 2088-2089 > > <https://reviews.apache.org/r/48803/diff/1/?file=1421645#file1421645line2088> > > > > Add a "not-recovered" check here. > > > > ``` > > ASSERT_EQ(1u, snapshot.values.count("prefix/log/recovered")); > > EXPECT_EQ(0, snapshot.values["prefix/log/recovered"]); > > ```
Added a TODO. Because of the bug mentioned in MESOS-5626, the destruction of the log will hang. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48803/#review138075 ----------------------------------------------------------- On June 16, 2016, 5:29 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48803/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 5:29 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5618 > https://issues.apache.org/jira/browse/MESOS-5618 > > > Repository: mesos > > > Description > ------- > > Added a test for replicated log metrics. > > > Diffs > ----- > > src/tests/log_tests.cpp 06bf5b8eb0336e015285ef749f50b8ad5be9aa62 > > Diff: https://reviews.apache.org/r/48803/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
