----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48527/#review138359 -----------------------------------------------------------
Ship it! I'll make necessary changes and commit this for you. - Jie Yu On June 17, 2016, 12:31 a.m., Dan Osborne wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48527/ > ----------------------------------------------------------- > > (Updated June 17, 2016, 12:31 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5592 > https://issues.apache.org/jira/browse/MESOS-5592 > > > Repository: mesos > > > Description > ------- > > Review: https://reviews.apache.org/r/48527 > > Fixes. > > Review: https://reviews.apache.org/r/48754 > > Code review fixes. > > > Checkpointed mutated networkinfo. > > > Added error message if args is specified. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 09890cedf2e7a1846bd1cb250e117be1680a1b80 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 106ff35320f37b2e75ed60381de1406459e6d515 > src/slave/containerizer/mesos/isolators/network/cni/paths.hpp > 8af50c11b00240ac1d24605b119acbd96aaa50be > src/slave/containerizer/mesos/isolators/network/cni/paths.cpp > b3fb0a32e3e74ca859ca58085efed5a87e4e626b > > Diff: https://reviews.apache.org/r/48527/diff/ > > > Testing > ------- > > > Thanks, > > Dan Osborne > >
