----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48925/#review138453 -----------------------------------------------------------
Quick drive-by style review... src/master/weights_handler.cpp (lines 94 - 95) <https://reviews.apache.org/r/48925/#comment203624> Remove the whitespaces here please - then, to make it fit into 80 chars, break at the argument. ``` response.mutable_get_weights()->add_weight_infos()->CopyFrom( weightInfo); ``` - Till Toenshoff On June 19, 2016, 12:01 p.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48925/ > ----------------------------------------------------------- > > (Updated June 19, 2016, 12:01 p.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: mesos-5495 > https://issues.apache.org/jira/browse/mesos-5495 > > > Repository: mesos > > > Description > ------- > > Add getWeights method in weights_handler. > > > Diffs > ----- > > src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe > src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d > src/master/weights_handler.cpp 25075357c5ac8450d2fa1790844802f121908e9e > src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf > > Diff: https://reviews.apache.org/r/48925/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
