> On June 20, 2016, 5:25 p.m., haosdent huang wrote: > > src/master/http.cpp, lines 1234-1242 > > <https://reviews.apache.org/r/48927/diff/2/?file=1423759#file1423759line1234> > > > > How about update it to reuse > > ``` > > Future<Response> Master::Http::_destroyVolumes( > > ```
Good catch! - Shuai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48927/#review138639 ----------------------------------------------------------- On June 20, 2016, 1:59 a.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48927/ > ----------------------------------------------------------- > > (Updated June 20, 2016, 1:59 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5502 > https://issues.apache.org/jira/browse/MESOS-5502 > > > Repository: mesos > > > Description > ------- > > Implemented DESTROY_VOLUMES Call in v1 master API. > > > Diffs > ----- > > src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe > src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d > > Diff: https://reviews.apache.org/r/48927/diff/ > > > Testing > ------- > > Please check https://reviews.apache.org/r/48938/ , which adds the test case > for both create/destroy volumes api. > > > Thanks, > > Shuai Lin > >