----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/#review138893 -----------------------------------------------------------
Ship it! LGTM! - Anand Mazumdar On June 21, 2016, 5:42 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48268/ > ----------------------------------------------------------- > > (Updated June 21, 2016, 5:42 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5509 > https://issues.apache.org/jira/browse/MESOS-5509 > > > Repository: mesos > > > Description > ------- > > Implemented SET_QUOTA Call in v1 master API. > > > Diffs > ----- > > include/mesos/v1/master/master.proto > c5b57ddc6aca0a62fb28523aee2fa579212da0ed > src/Makefile.am 2333f2550ab83453f41cc2567d28d4941e21c26d > src/master/http.cpp 3a53ef74f3e80e832804a21cebe0fc9e405420cb > src/master/master.hpp 2064f849edf6f78b009ecfcc4b15b6831834345c > src/master/quota_handler.cpp 567f1c2cc59b859227a8b48c6086ce3f8049f14d > src/tests/api_tests.cpp 55df322f6a843e52d67bb09d3fe763739515602b > > Diff: https://reviews.apache.org/r/48268/diff/ > > > Testing > ------- > > On Ubuntu 16.04: > sudo GTEST_FILTER="*MasterAPITest.SetQuota*" make -j4 check > > [==========] Running 2 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 2 tests from ContentType/MasterAPITest > [ RUN ] ContentType/MasterAPITest.SetQuota/0 > [ OK ] ContentType/MasterAPITest.SetQuota/0 (129 ms) > [ RUN ] ContentType/MasterAPITest.SetQuota/1 > [ OK ] ContentType/MasterAPITest.SetQuota/1 (98 ms) > [----------] 2 tests from ContentType/MasterAPITest (227 ms total) > > [----------] Global test environment tear-down > [==========] 2 tests from 1 test case ran. (236 ms total) > [ PASSED ] 2 tests. > > > Thanks, > > Abhishek Dasgupta > >