> On June 21, 2016, 9:39 p.m., Benjamin Mahler wrote: > > src/webui/master/static/js/controllers.js, lines 151-154 > > <https://reviews.apache.org/r/48911/diff/1/?file=1423454#file1423454line151> > > > > This still looks incorrect, we need to set the stopped time only if the > > last state is terminal. Can you add an isTerminal helper and use that here > > to check the last state? > > > > Please pull this fix into a patch separate from this one.
FYI I added a TODO for us to follow up on this: ``` + // TODO(bmahler): Only set the terminal time if the last state is terminal! + task.finish_time = + task.statuses[task.statuses.length - 1].timestamp * 1000; ``` - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48911/#review138946 ----------------------------------------------------------- On June 18, 2016, 8:22 p.m., Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48911/ > ----------------------------------------------------------- > > (Updated June 18, 2016, 8:22 p.m.) > > > Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added orphan tasks count on left side table. > Added orphan tasks table under completed tasks. > Fixed setting tasks.finish_time, if task is running > this value won't be set. > > > Diffs > ----- > > src/webui/master/static/home.html a8c8c20ce7659eecd621fcf7714fac9274155d67 > src/webui/master/static/js/controllers.js > fcb6242003326ab608aa72e6b881f8dbb9822b94 > > Diff: https://reviews.apache.org/r/48911/diff/ > > > Testing > ------- > >  > > > Thanks, > > Tomasz Janiszewski > >
