> On June 13, 2016, 12:02 p.m., Joris Van Remoortere wrote: > >
Hi, Joris, so sorry for this late reply. I have made some further benchmarking and no negative impact was found when evaluating this change on other existing test cases, especially those for resource and allocator. And I have proposed another follow-up JIRA to state this is just an interim fix and we expect c++ based resource definition as permanent solution. Thank you so much. - Yanyan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review137281 ----------------------------------------------------------- On June 15, 2016, 3:39 a.m., Yanyan Hu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48593/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 3:39 a.m.) > > > Review request for mesos, Guangya Liu and Joris Van Remoortere. > > > Bugs: MESOS-5425 > https://issues.apache.org/jira/browse/MESOS-5425 > > > Repository: mesos > > > Description > ------- > > This patch reimplement Ranges subtraction using > IntervalSet data type: Ranges values will be > converted to IntervalSet values for subtraction > and the result will be converted back to Ranges > after subtraction is done. This change is for > fixing jira MESOS-5425. > > > Diffs > ----- > > src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b > src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 > > Diff: https://reviews.apache.org/r/48593/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yanyan Hu > >
