----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49054/#review139024 -----------------------------------------------------------
Ship it! LGTM! Thanks for taking this. BTW, I remember I saw similar issue once, in which case tests expecting a failure cannot tell which type of failure it is expecting. - Gilbert Song On June 21, 2016, 5 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49054/ > ----------------------------------------------------------- > > (Updated June 21, 2016, 5 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-5660 > https://issues.apache.org/jira/browse/MESOS-5660 > > > Repository: mesos > > > Description > ------- > > https://reviews.apache.org/r/48954/ did not set the > `--executor_environment_variables` agent flag in the correct place. > This caused the balloon framework to fail with flag validation errors. > Since this test expects a failure, the test would always succeed > for the wrong reason. > > > Diffs > ----- > > src/tests/balloon_framework_test.sh > 54129fb11004c86026086f410198afee002ac088 > > Diff: https://reviews.apache.org/r/49054/diff/ > > > Testing > ------- > > sudo ./bin/mesos-tests.sh > > > Thanks, > > Joseph Wu > >
