----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48988/#review139087 -----------------------------------------------------------
src/tests/containerizer/rootfs.hpp (line 104) <https://reviews.apache.org/r/48988/#comment204237> This should be called 'files'? src/tests/containerizer/rootfs.hpp (line 137) <https://reviews.apache.org/r/48988/#comment204238> I am not sure if this logic still applies. For instance, if `/lib64 -> /xxx/lib64`. The realpath of `/lib64/librt.so.1` is `/xxx/lib64/librt.so.1`. However, `islink('/lib64/librt.so.1') == false`. I think you should test if `realpath.get() == file`? - Jie Yu On June 21, 2016, 2:45 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48988/ > ----------------------------------------------------------- > > (Updated June 21, 2016, 2:45 a.m.) > > > Review request for mesos, Zhiwei Chen, haosdent huang, Artem Harutyunyan, Jie > Yu, and Timothy Chen. > > > Bugs: MESOS-4943 > https://issues.apache.org/jira/browse/MESOS-4943 > > > Repository: mesos > > > Description > ------- > > Reduced test linux rootfs size. > > > Diffs > ----- > > src/tests/containerizer/rootfs.hpp 19ec7bf50e599f5420453e8cb7d12357770d3fd8 > > Diff: https://reviews.apache.org/r/48988/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
