-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48375/
-----------------------------------------------------------
(Updated June 23, 2016, 4:34 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Rebased after some changes pushed to master already.
Bugs: MESOS-5563
https://issues.apache.org/jira/browse/MESOS-5563
Repository: mesos
Description
-------
Previously, components outside of
`src/slave/containerizers/mesos/isolators/gpu` had to protect their
\#includes for certain Nvidia header files with the
ENABLE_NVIDIA_GPU_SUPPORT flag. Other headers strictly *could not* be
wrapped in this flag.
This commit cleans up this header madness, by creating a common
"nvidia.hpp" header that takes care of all the dependencies. All
componenents outside of `src/slave/containerizers/mesos/isolators/gpu`
now only need to \#include this one header instead of managing
everything themselves.
Diffs (updated)
-----
src/Makefile.am 23cac95a805e46d216e9479fea09f2c1619c45a5
src/slave/containerizer/containerizer.cpp
5dc545bd201dca7d751ac4e7dd09d4eac07d428e
src/slave/containerizer/docker.hpp 9b0a5a76e457006119e657ee8f627dcd1326c0ce
src/slave/containerizer/mesos/containerizer.hpp
a1a00020668f6da8d611f26e5637afffc87d09ba
src/slave/containerizer/mesos/containerizer.cpp
d984efd4742ec084d66538c48a36ea768832324d
src/slave/containerizer/mesos/isolators/gpu/components.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/gpu/isolator.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp
28ad0b3d1d8e7642a93e4ebb0fcc399e182be393
src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp
cfb23244d0e6f6e0d94685a35826b35f3297c6fe
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp
a01c88660bb3c5435802ebd1cbc7ef84323c5795
Diff: https://reviews.apache.org/r/48375/diff/
Testing
-------
GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests
Thanks,
Kevin Klues
