----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48968/#review139354 -----------------------------------------------------------
Ship it! Ship It! - Neil Conway On June 23, 2016, 9:29 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48968/ > ----------------------------------------------------------- > > (Updated June 23, 2016, 9:29 p.m.) > > > Review request for mesos, Anand Mazumdar, Neil Conway, and Vinod Kone. > > > Bugs: MESOS-5664 > https://issues.apache.org/jira/browse/MESOS-5664 > > > Repository: mesos > > > Description > ------- > > This patch fixes a bug in which invalid resources supplied > to the master's '/reserve', '/unreserve', '/create-volumes', > and '/destroy-volumes' HTTP endpoints were silently > ignored, without returning an error as expected. > > > Diffs > ----- > > src/master/http.cpp 70f084b84db90fde20c05d2354be190f28e72996 > src/tests/persistent_volume_endpoints_tests.cpp > b66c337808af673b6f98bbc9807d5bd1cb34731e > src/tests/reservation_endpoints_tests.cpp > e029f4e1b1da434fd6eb267675528ab97370be24 > > Diff: https://reviews.apache.org/r/48968/diff/ > > > Testing > ------- > > New tests were added - `PersistentVolumeEndpointsTest.InvalidVolume` and > `ReservationEndpointsTest.InvalidResource` - to check that requests to the > affected endpoints will fail correctly when invalid resources are supplied. I > checked that these tests failed before the fix, and passed after. > > `make check` on OSX was used to test as well. > > > Thanks, > > Greg Mann > >
